Skip to content

ui/hooks: sidebar drawer list #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 12, 2020
Merged

ui/hooks: sidebar drawer list #1021

merged 3 commits into from
Nov 12, 2020

Conversation

dctalbot
Copy link
Contributor

@dctalbot dctalbot commented Nov 11, 2020 •
edited
Loading

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Use hooks for SideBarDrawerList

Which issue(s) this PR fixes:
Part of #923

@dctalbot dctalbot mentioned this pull request Nov 11, 2020
Closed
KatieMSB
KatieMSB reviewed Nov 11, 2020
View reviewed changes
KatieMSB
KatieMSB previously approved these changes Nov 11, 2020
View reviewed changes
@dctalbot dctalbot requested a review from KatieMSB November 12, 2020 16:30
@dctalbot dctalbot merged commit b687fe7 into master Nov 12, 2020
@dctalbot dctalbot deleted the hooks-sidebar-drawer-list branch November 12, 2020 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mastercactapus mastercactapus mastercactapus left review comments

@Forfold Forfold Forfold approved these changes

@KatieMSB KatieMSB KatieMSB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dctalbot @mastercactapus @Forfold @KatieMSB