Skip to content

Conversation

pnengchu
Copy link
Contributor

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
converted class component to hook for IntegrationKeyAPI.js

Which issue(s) this PR fixes:
Part of #923

render() {
const protocol = window.location.protocol || 'https:'
const host = window.location.host
export function IntegrationKeyAPI() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export function IntegrationKeyAPI() {
export default function IntegrationKeyAPI() {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed, changes made.

@dctalbot
Copy link
Contributor

I think we need to keep the import React from 'react' for the JSX transpiling to work

@pnengchu pnengchu merged commit b1e7104 into master Nov 12, 2020
@pnengchu pnengchu deleted the hooks-IntegrationKeyAPI branch November 12, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants