Skip to content

Conversation

KatieMSB
Copy link
Collaborator

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Converts PolicyEditDialog to use hooks.

Which issue(s) this PR fixes:
Part of #923

Co-authored-by: Nathaniel Caza <mastercactapus@gmail.com>
Copy link
Contributor

@dctalbot dctalbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious what you think about this. Even if it's not a bug today, it feels fragile to me.

Co-authored-by: David Talbot <dctalbot@umich.edu>
dctalbot
dctalbot previously approved these changes Nov 16, 2020
dctalbot
dctalbot previously approved these changes Nov 17, 2020
@KatieMSB KatieMSB merged commit f1d763b into master Nov 20, 2020
@KatieMSB KatieMSB deleted the hooks-policy-edit-dialog branch November 20, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants