Skip to content

ui/hooks: convert errors #1009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2020
Merged

ui/hooks: convert errors #1009

merged 1 commit into from
Nov 10, 2020

Conversation

KatieMSB
Copy link
Collaborator

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Converts PageNotFound, ObjectNotFound, and GenericError to functions.

Which issue(s) this PR fixes:
Part of #923

@KatieMSB KatieMSB mentioned this pull request Nov 10, 2020
Closed
@Forfold Forfold merged commit 4307485 into master Nov 10, 2020
@Forfold Forfold deleted the hooks-errors branch November 10, 2020 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mastercactapus mastercactapus mastercactapus approved these changes

@Forfold Forfold Forfold approved these changes

+1 more reviewer

@dctalbot dctalbot dctalbot approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KatieMSB @mastercactapus @Forfold @dctalbot