Skip to content

ui/hooks: dialog title wrapper #1005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2020
Merged

ui/hooks: dialog title wrapper #1005

merged 1 commit into from
Nov 9, 2020

Conversation

KatieMSB
Copy link
Collaborator

@KatieMSB KatieMSB commented Nov 9, 2020

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Converted dialogTitleWrapper.js to use hooks.

Which issue(s) this PR fixes:
Part of #923

@KatieMSB KatieMSB mentioned this pull request Nov 9, 2020
Closed
@KatieMSB KatieMSB merged commit 6c72036 into master Nov 9, 2020
@KatieMSB KatieMSB deleted the hooks-dialog-title-wrapper branch November 9, 2020 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mastercactapus mastercactapus mastercactapus approved these changes

@Forfold Forfold Forfold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KatieMSB @mastercactapus @Forfold