Skip to content

Conversation

dctalbot
Copy link
Contributor

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Converts WideSideBar.js to hooks, and then to typescript

Which issue(s) this PR fixes:
Part of #923

@dctalbot
Copy link
Contributor Author

Probably easiest to review this by looking at each commit on its own. I figured the component was small enough that the typescript wouldn't be too much overhead for reviewing.

Copy link
Contributor

@Forfold Forfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mastercactapus mastercactapus merged commit e3836af into master Dec 1, 2020
@mastercactapus mastercactapus deleted the hooks-wide-sidebar branch December 1, 2020 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants