Add support for UUID keys comparison #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

dokshina merged 14 commits into master from gh-84

Dec 7, 2020

Contributor

akudiyar commented Nov 11, 2020 •

edited

Loading

Add support for indexes with UUID key parts. UUID comparison is done via the uuid:str() method and may be further replaced with a more efficient comparison using tt_uuid_compare (see tarantool/tarantool#5511)

I didn't forget about

Tests
Changelog
Documentation

Closes #84

akudiyar requested a review from dokshina

November 11, 2020 13:00

dokshina reviewed

View reviewed changes

crud/select/comparators.lua Outdated Show resolved Hide resolved

dokshina reviewed

View reviewed changes

test/unit/select_comparators_test.lua Outdated Show resolved Hide resolved

dokshina reviewed

View reviewed changes

test/unit/select_comparators_test.lua Show resolved Hide resolved

dokshina reviewed

View reviewed changes

test/integration/select_test.lua Outdated Show resolved Hide resolved

dokshina reviewed

View reviewed changes

test/integration/select_test.lua Outdated Show resolved Hide resolved

olegrok reviewed

View reviewed changes

crud/common/types.lua Outdated Show resolved Hide resolved

crud/common/types.lua Outdated Show resolved Hide resolved

crud/common/types.lua Outdated Show resolved Hide resolved

test/unit/select_comparators_test.lua Outdated Show resolved Hide resolved

test/unit/select_comparators_test.lua Show resolved Hide resolved

test/integration/select_test.lua Outdated Show resolved Hide resolved

akudiyar added 7 commits

November 11, 2020 23:25


          Add support for UUID keys comparison

d4e2b6d


          Improve unit test stability

5877b4f


          Fence the test code for 2.4.x for testing on other versions

453931c


          Fixes after review comments

b19f065


          Move collation-aware comparators to the types module

bd2fc70


          Support UUID values in dynamic filters generation

6d626d4


          Update CHANGELOG

a09ae2e

akudiyar force-pushed the gh-84 branch from c8036b6 to a09ae2e Compare

November 11, 2020 20:26

dokshina reviewed

View reviewed changes

test/integration/select_test.lua Outdated Show resolved Hide resolved

dokshina reviewed

View reviewed changes

test/unit/select_comparators_test.lua Outdated Show resolved Hide resolved

dokshina reviewed

View reviewed changes

crud/common/utils.lua Outdated Show resolved Hide resolved

dokshina reviewed

View reviewed changes

test/unit/select_comparators_test.lua Show resolved Hide resolved

dokshina reviewed

View reviewed changes

crud/select/filters.lua Outdated Show resolved Hide resolved

dokshina reviewed

View reviewed changes

crud/select/filters.lua Outdated Show resolved Hide resolved

dokshina reviewed

View reviewed changes

crud/select/filters.lua Outdated Show resolved Hide resolved

dokshina reviewed

View reviewed changes

crud/common/types.lua Outdated Show resolved Hide resolved

dokshina reviewed

View reviewed changes

crud/common/types.lua Outdated Show resolved Hide resolved

dokshina reviewed

View reviewed changes

crud/common/types.lua Outdated Show resolved Hide resolved

dokshina reviewed

View reviewed changes

crud/common/types.lua Outdated Show resolved Hide resolved

dokshina reviewed

View reviewed changes

crud/common/types.lua Outdated Show resolved Hide resolved

akudiyar added 2 commits

November 12, 2020 16:17


          Add test for dynamic filters, fix review comments

225e990


          Do not make GC suffer from runtime closures in type comparators

d56a654

dokshina reviewed

View reviewed changes

crud/select/type_comparators.lua Outdated Show resolved Hide resolved

dokshina reviewed

View reviewed changes

crud/select/filters.lua Show resolved Hide resolved

akudiyar added 4 commits

December 2, 2020 17:28


          Merge master

84279ae


          Renaming and refactoring back according to comments

4b28eba


          Merge branch 'master' into gh-84

4986b4c


          Move uuid check in filters.lua out from cdata check

cce744c

akudiyar requested review from dokshina, olegrok and mtrempoltsev

December 3, 2020 17:07

dokshina approved these changes

View reviewed changes


          Merge branch 'master' into gh-84

d807cbc

Contributor

dokshina commented Dec 7, 2020

Please, rebase your branch and I will merge it immediately.

dokshina merged commit c6eb641 into master

dokshina deleted the gh-84 branch

December 7, 2020 11:47

DifferentialOrange mentioned this pull request

scan: extention types filters #423

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet