coverage: fix loaded function name #353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we load flatten functions for spaces with `@flatten` source. Source starting with @ assumes that it describes the file name, yet here it isn't. Then luacov fails to find "flatten" file on coverage info build. When we do not specify source explicitly, the whole string became the source. It will not confuse luacov anymore (it just ignores them), and it's more helpful for debug. 1. https://www.lua.org/manual/5.2/manual.html#pdf-load Closes #249
c0ef1f6 to
8b19c30
Compare
GRISHNOV
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we load flatten functions for spaces with
@flattensource. Source starting with @ assumes that it describes the file name, yet here it isn't. Then luacov fails to find "flatten" file on coverage info build.When we do not specify source explicitly, the whole string became the source. It will not confuse luacov anymore (it just ignores them), and it's more helpful for debug.
Closes #249
I didn't forget about