Skip to content

config: move role start and stop to _post_apply() #9651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2024
Merged

config: move role start and stop to _post_apply() #9651

merged 1 commit into from
Feb 7, 2024

Conversation

ImeevMA
Copy link
Collaborator

@ImeevMA ImeevMA commented Feb 5, 2024

Roles are now started and stopped at the "post_apply" stage rather than at the "apply" stage. This allows require('config'):get() to correctly return the configuration that is being applied.

Closes #9649

@ImeevMA ImeevMA requested review from Totktonada and a team as code owners February 5, 2024 14:01
@coveralls
Copy link

coveralls commented Feb 5, 2024 •
edited
Loading

Coverage Status

coverage: 86.898% (-0.007%) from 86.905%
when pulling 57c4a29 on ImeevMA:imeevma/gh-9649-config-get-in-roles
into 9e9ea6d
on tarantool:master.

Totktonada
Totktonada approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is consistent with how the application code is executed and I think it is OK to consider this change as a bugfix.

I think that we should backport it to 3.0 as well.

@ImeevMA ImeevMA force-pushed the imeevma/gh-9649-config-get-in-roles branch from 4356ac3 to 906dba3 Compare February 7, 2024 08:32
@ImeevMA
config: move role start and stop to _post_apply()
57c4a29 
Roles are now started and stopped at the "post_apply" stage rather than
at the "apply" stage. This allows require('config'):get() to correctly
return the configuration that is being applied.

Closes tarantool#9649

NO_DOC=bugfix
@ImeevMA ImeevMA force-pushed the imeevma/gh-9649-config-get-in-roles branch from 906dba3 to 57c4a29 Compare February 7, 2024 08:38
@ImeevMA
Copy link
Collaborator Author

ImeevMA commented Feb 7, 2024

Sorry, I expanded the test and rewrote the changelog. @Totktonada @ochaplashkin @xuniq can you take a look at it again?

@Totktonada Totktonada added the full-ci Enables all tests for a pull request label Feb 7, 2024
@Totktonada Totktonada merged commit ebb170c into tarantool:master Feb 7, 2024
@Totktonada Totktonada mentioned this pull request Feb 7, 2024
Merged
@Totktonada
Copy link
Member

Pushed to master (future 3.1.0 release), backported to release/3.0 (future 3.0.2 release) in PR #9660.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Totktonada Totktonada Totktonada approved these changes

@xuniq xuniq xuniq approved these changes

+1 more reviewer

@ochaplashkin ochaplashkin ochaplashkin approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
full-ci Enables all tests for a pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return the new configuration on require('config'):get() in the role.
5 participants
@ImeevMA @coveralls @Totktonada @ochaplashkin @xuniq