fix(storage): Make unlimited requests great again #646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated request count limit checks in FS, InMemory, and Redis storage implementations to ensure they only execute when maxRequests is greater than zero. This change enhances code clarity and prevents unnecessary operations when the limit is not set.
Added the gocyclo linting directive to the NewRequest function to improve code maintainability by addressing cyclomatic complexity. This change helps ensure the function remains within acceptable complexity limits for better readability and testing.
a7d743b to
aafd978
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated request count limit checks in FS, InMemory, and Redis storage implementations to ensure they only execute when maxRequests is greater than zero. This change enhances code clarity and prevents unnecessary operations when the limit is not set.
Fixes #645