fix(storage): prevent nil-pointer dereference on auto-created sessions #611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in combination with `--auto-create-sessions` options, the expiry check can not be performed since we get nil for the session on the initial incoming webhook
|
Thank you for your PR! Could you clarify a bit - does this address a specific bug? If so, could you describe how to reproduce it? I'm a bit confused because if we're already checking for existence in the map using a boolean return value, why isn't that sufficient in this case? |
|
Thanks for having a look. With the For example: run When doing this, I get a nil-pointer dereference because the session load returns |
|
@tessig Thank you, mate! You've done a great job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
in combination with
--auto-create-sessionsoptions, the expiry check can not be performed since we get nil for the session on the initial incoming webhookChecklist