✨ feat: Add option to keep original file after compression #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `--keep-original-file` option to preserve the original file with a `.orig` extension alongside the compressed version. This allows users to retain the original files for archival or other purposes.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Configured the `wsl_v5` linter in `.golangci.yml` to enforce whitespace rules. Also, fixed whitespace issues reported by the linter in `main.go` and `app.go`. The configuration allows first-in-block and sets branch-max-lines to 2. Renamed `wsl` to `wsl_v5` in `.golangci.yml`.
Refactors the `replaceFiles` function to improve error handling when the `KeepOriginalFile` option is enabled. Wraps the file copying logic in a closure to ensure deferred `Close()` calls are executed, even if an error occurs during the copying process. This prevents potential resource leaks and ensures proper cleanup.
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new --keep-original-file option that preserves the original image file with a .orig extension alongside the compressed version, allowing users to retain original files for archival purposes. The implementation also includes updates to linter configuration and some code formatting improvements.
- Adds
KeepOriginalFileoption to CLI with corresponding flag and environment variable support - Implements file copying logic in the compression workflow to create
.origbackup files - Updates linter configuration from
wsltowsl_v5with new settings
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/cli/options.go | Adds KeepOriginalFile boolean field to options struct with default value |
| internal/cli/app.go | Implements CLI flag definition and file copying logic in replaceFiles method |
| README.md | Documents the new --keep-original-file option in usage instructions |
| .golangci.yml | Updates linter configuration from wsl to wsl_v5 with new settings |
| cmd/tinifier/main.go | Updates linter directive from wsl to wsl_v5 |
| pkg/tinypng/client_test.go | Adds blank line (formatting change) |
| internal/errgroup/errgroup_test.go | Removes blank line (formatting change) |
| internal/cli/cmd/tools_for_test.go | Adds blank lines around loop (formatting change) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
--keep-original-fileoption to preserve the original file with a.origextension alongside the compressed version. This allows users to retain the original files for archival or other purposes.Related issue: #103