Skip to content
This repository was archived by the owner on Jan 6, 2025. It is now read-only.
This repository was archived by the owner on Jan 6, 2025. It is now read-only.

openh264 for Android arm32 does not use COMMON_ASM_ARM_SRCS #367

@alexcohn

Description

@alexcohn

Description
Building openh264 as part of android --full, neon assembly files are excluded. Is this intentional?

Expected behavior
I thought assembly files should be included:

$(COMMON_SRCDIR)/arm/copy_mb_neon.S\
$(COMMON_SRCDIR)/arm/deblocking_neon.S\
$(COMMON_SRCDIR)/arm/expand_picture_neon.S\
$(COMMON_SRCDIR)/arm/intra_pred_common_neon.S\
$(COMMON_SRCDIR)/arm/mc_neon.S\

Current behavior
These files are excluded, by virtue of android-openh264.sh massaging some of original .mk files.

Environment

  • Platform: Android
  • Architecture: arm-v7a-neon
  • Version: 4.3.1
  • Source branch: master
  • Android NDK version: 21.1.6273396

Metadata

Metadata

Assignees

Labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions