Skip to content

Conversation

mcoulombe
Copy link
Contributor

What this PR does / why we need it:
Prior PR (#503) forgot to adjust some acceptance tests for the oauth client resource.

Which issue this PR fixes (use fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged):

Fixes #cleanup

Special notes for your reviewer:
Local results with the adjustment:
Screenshot 2025-05-12 at 1 03 24 PM

Fixes #cleanup

Signed-off-by: mcoulombe <max@tailscale.com>
@ghost
Copy link

ghost commented May 12, 2025

Pull Request Revisions

RevisionDescription
r1
Added KeyType to OAuth client testsUpdated test fixtures by adding KeyType = "client" to expected OAuth client objects in test scenarios

☑️ AI review skipped for r1
Help React with emojis to give feedback on AI-generated reviews:
  • 👍 means the feedback was helpful and actionable
  • 👎 means the feedback was incorrect or unhelpful
💬 Replying to feedback with a comment helps us improve the system. Your input also contributes to shaping future interactions with the AI reviewer.

We'd love to hear from you—reach out anytime at team@review.ai.

@mcoulombe mcoulombe requested a review from mpminardi May 12, 2025 17:03
@mcoulombe mcoulombe merged commit 24a54bb into main May 12, 2025
5 checks passed
@mcoulombe mcoulombe deleted the max/fix-oauth-client-tests branch May 12, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants