tailscale: add reset_acl_on_destroy attribute to tailscale_acl
#476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxtoacart
approved these changes
Feb 6, 2025
| return nil | ||
| } | ||
| client := m.(*tsclient.Client) | ||
|
|
There was a problem hiding this comment.
Nit: I would have expected this whitespace before line 163 instead of after, but that may very well just be me.
There was a problem hiding this comment.
Whoops good call this does look a little wonky, will fix.
tailscale/resource_acl.go
Outdated
|
|
||
| // Setting the ACL to an empty string resets its value to the default. | ||
| if err := client.PolicyFile().Set(ctx, "", ""); err != nil { | ||
| return diagnosticsError(err, "Failed to set ACL") |
There was a problem hiding this comment.
"Failed to set ACL" or "Failed to reset ACL" or "Failed to delete ACL" or ???
There was a problem hiding this comment.
Hmm maybe "Failed to reset ACL" would be the most accurate to what the intent here is? Will adjust.
f233aef to
42a2c93
Compare
Add an optional `reset_acl_on_destroy` attribute to the `tailscale_acl` resource which causes the ACL on the Taislcale control plane to be reset to the default ACL when the resource is destroyed. Updates #426 Signed-off-by: Mario Minardi <mario@tailscale.com>
42a2c93 to
60072eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an optional
reset_acl_on_destroyattribute to thetailscale_aclresource which causes the ACL on the Taislcale control plane to be reset to the default ACL when the resource is destroyed.Updates #426