tailscale: add contacts resource
#387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3eee341 to
ca92fe6
Compare
9672b7c to
a0ed2e9
Compare
oxtoacart
approved these changes
Jul 31, 2024
tailscale/resource_contacts.go
Outdated
| return diagnosticsError(err, "Failed to fetch contacts") | ||
| } | ||
|
|
||
| accountMap := []map[string]interface{}{ |
There was a problem hiding this comment.
These feel somewhat repetitive, could maybe be pulled into a function like buildContact() or something?
There was a problem hiding this comment.
Have added a buildContactMap function to clean this up a bit.
tailscale/resource_contacts.go
Outdated
| client := m.(*tailscale.Client) | ||
|
|
||
| if d.HasChange("account") { | ||
| account := d.Get("account").(*schema.Set).List() |
There was a problem hiding this comment.
These sections feel a little repetitive, maybe they could be pulled into a helper function?
There was a problem hiding this comment.
Made an updateContact helper to encapsulate some of the repetitive bits here.
9ff27ef to
0b27a26
Compare
Add a `tailscale_contacts` resource to allow for managing tailscale contacts settings via Terraform. Updates tailscale/corp#21631 Signed-off-by: Mario Minardi <mario@tailscale.com>
a0ed2e9 to
eccd7ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
tailscale_contactsresource to allow for managing tailscale contacts settings via Terraform.Updates https://github.com/tailscale/corp/issues/21631