tailscale: add initial acceptance testing logic #385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1f8f161 to
6284e65
Compare
8dd4a24 to
00b79e1
Compare
oxtoacart
reviewed
Aug 1, 2024
|
|
||
| Tests in this repo that are prefixed with `TestAcc` are acceptance tests which run against a real instance of the tailscale control plane. | ||
| These tests are skipped unless the `TF_ACC` environment variable is set. | ||
| Running `make testacc` sets the `TF_ACC` variable and runs the tests. |
There was a problem hiding this comment.
Nit - maybe mention that this is internal to the Terraform code and include link to https://developer.hashicorp.com/terraform/plugin/sdkv2/testing/acceptance-tests#requirements-and-recommendations
oxtoacart
approved these changes
Aug 1, 2024
00b79e1 to
9ff27ef
Compare
6284e65 to
f6ff2f6
Compare
Add initial acceptance testing setup logic and a basic acceptance test for the new webhook resource. Updates tailscale/corp#21842
9ff27ef to
0b27a26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial acceptance testing setup logic and a basic acceptance test for the new webhook resource.
Updates https://github.com/tailscale/corp/issues/21842