Skip to content

chore: introduce and use TargetRuntime #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 1, 2024
Merged

chore: introduce and use TargetRuntime #1086

merged 3 commits into from
Feb 1, 2024

Conversation

mogery
Copy link
Contributor

@mogery mogery commented Feb 1, 2024

Summary:
Adds TargetRuntime struct and uses it for ConfigReader and AppContext to simplify piping.

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions bot added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label Feb 1, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 1, 2024 •
edited
Loading

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (78f90f6) 88.27% compared to head (de07186) 88.26%.

Files Patch % Lines
src/cli/tc.rs 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1086      +/-   ##
==========================================
- Coverage   88.27%   88.26%   -0.02%     
==========================================
  Files         101      102       +1     
  Lines       11005    10994      -11     
==========================================
- Hits         9715     9704      -11     
  Misses       1290     1290

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tusharmath tusharmath changed the title feat: introduce and use TargetRuntime chore: introduce and use TargetRuntime Feb 1, 2024
tusharmath
tusharmath reviewed Feb 1, 2024
View reviewed changes
tusharmath
tusharmath reviewed Feb 1, 2024
View reviewed changes
tusharmath
tusharmath reviewed Feb 1, 2024
View reviewed changes
@github-actions github-actions bot added the type: chore Routine tasks like conversions, reorganization, and maintenance work. label Feb 1, 2024
@tusharmath tusharmath enabled auto-merge (squash) February 1, 2024 12:09
@tusharmath
Copy link
Contributor

/tip 50$

@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Feb 1, 2024

🎉🎈 @mogery has been awarded $50! 🎈🎊

@tusharmath tusharmath merged commit 9d323a6 into tailcallhq:main Feb 1, 2024
@mogery mogery deleted the mog/targetruntime branch February 1, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tusharmath tusharmath tusharmath approved these changes

Assignees
No one assigned
Labels
💰 Rewarded type: chore Routine tasks like conversions, reorganization, and maintenance work. type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mogery @tusharmath