Skip to content

Replace / with \ in vendor dirs on Windows to match llvm cov #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 19, 2025
Merged

Replace / with \ in vendor dirs on Windows to match llvm cov #442

merged 2 commits into from
Jul 19, 2025

Conversation

LittleBoxOfSunshine
Copy link
Contributor

Fixes #441. Since \ and / are reserved characters in file paths on Windows, we can fix the issue with a naive string replace.

Tested by introducing a stub file:
image

Before:
image


image

After:
image
image

taiki-e
taiki-e approved these changes Jul 19, 2025
View reviewed changes
Copy link
Owner

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@taiki-e taiki-e merged commit 1056116 into taiki-e:main Jul 19, 2025
34 checks passed
@taiki-e
Copy link
Owner

taiki-e commented Jul 19, 2025

Published in v0.6.18.

@LittleBoxOfSunshine LittleBoxOfSunshine deleted the chhenk/win-vendor-fix branch July 19, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default vendor filter fails on Windows when forward slashes appear in path
3 participants
@LittleBoxOfSunshine @taiki-e @chhenk