Skip to content

Remove dependency on is_executable #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2025
Merged

Remove dependency on is_executable #422

merged 1 commit into from
Feb 23, 2025

Conversation

taiki-e
Copy link
Owner

@taiki-e taiki-e commented Feb 21, 2025 •
edited
Loading

Due to its behavior of always returning true on WSL, the value returned by this crate could not be trusted, and we were already using our own extension checks to handle that problem.

@taiki-e taiki-e force-pushed the is_executable branch 3 times, most recently from 5d217d1 to 7fcc5b3 Compare February 21, 2025 17:49
@taiki-e taiki-e marked this pull request as draft February 21, 2025 18:12
@taiki-e taiki-e force-pushed the is_executable branch 2 times, most recently from a7ad6e1 to 98719cd Compare February 23, 2025 19:01
@taiki-e taiki-e marked this pull request as ready for review February 23, 2025 19:02
@taiki-e taiki-e force-pushed the is_executable branch 3 times, most recently from 83f3c95 to 900287c Compare February 23, 2025 19:12
@taiki-e taiki-e merged commit 3df8c10 into main Feb 23, 2025
33 checks passed
@taiki-e taiki-e deleted the is_executable branch February 23, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@taiki-e