include-build/roborazzi-gradle-plugin/src/main/java/io/github/takahirom/roborazzi/GenerateComposePreviewRobolectricTestsExtension.kt (1)

352-368: Consider pre-release semantics in version comparisons (optional)

parseVersion drops non-numeric suffixes, so "0.7.0-alpha01" equals "0.7.0". If you intend pre-releases to be considered lower than stable (common practice), extend the comparator to treat versions with pre-release tags as lower when numeric parts are equal.

include-build/roborazzi-gradle-plugin/src/integrationTest/java/io/github/takahirom/roborazzi/PreviewGenerateTest.kt (1)

101-101: Avoid duplicating the minimum version — reuse the plugin’s constant

To prevent drift between the plugin and tests, read the minimum required version from the plugin constant instead of hardcoding it here.

Apply this diff (after adding MIN_COMPOSABLE_PREVIEW_SCANNER_VERSION in the plugin):

-    var composablePreviewScannerVersion = "0.7.0"
+    var composablePreviewScannerVersion = MIN_COMPOSABLE_PREVIEW_SCANNER_VERSION

Note: Ensure the test source set can access the constant (internal is fine within the same module).

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

include-build/roborazzi-gradle-plugin/src/main/java/io/github/takahirom/roborazzi/GenerateComposePreviewRobolectricTestsExtension.kt (1)

23-24: Good: centralized min-version constant; please remove remaining hard-coded "0.7.0" literals in tests/docs

Centralizing the minimum ComposablePreviewScanner version improves consistency and avoids drift.

Run this to ensure there are no stray "0.7.0" literals left (tests/docs/build logic):

#!/bin/bash
# Find hard-coded occurrences of "0.7.0" except in version catalogs
rg -n --hidden --glob '!.git' --glob '!**/build/**' --glob '!gradle/libs.versions.toml' $'0\\.7\\.0'

include-build/roborazzi-gradle-plugin/src/main/java/io/github/takahirom/roborazzi/GenerateComposePreviewRobolectricTestsExtension.kt (1)

360-363: Don’t swallow resolution exceptions; log at debug for diagnosability

Currently the exception is dropped, making troubleshooting hard and flagged by detekt as SwallowedException. At minimum, log at debug.

Apply this minimal diff if you keep the current approach:

-      } catch (e: Exception) {
-        // If resolution fails, we can't determine the version
-        null
-      }
+      } catch (e: Exception) {
+        project.logger.debug("Roborazzi: Failed to resolve ComposablePreviewScanner version: ${e.message}", e)
+        null
+      }

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

include-build/roborazzi-gradle-plugin/src/test/java/io/github/takahirom/roborazzi/VersionComparisonTest.kt (1)

16-23: Good move: parameterized tests address the earlier feedback

Switching to JUnit4 Parameterized with constructor injection makes each case independent and readable. This also aligns with the prior suggestion about parameterized tests.

sample-generate-preview-tests-multiplatform/src/commonMain/kotlin/com/github/takahirom/preview/tests/Previews.kt (1)

25-29: Nit: Function name suggests parameters but none are present—clarify intent

To avoid confusion, clarify this is a placeholder for future parameterized previews, or actually add a preview parameter. Minimal change suggestion below adds a short KDoc and adjusts the text to reflect “placeholder”.

-@Preview
-@Composable
-fun PreviewWithParameters() {
-  Text("Preview with parameters (for future Compose Multiplatform 1.9.0+ support)!")
-}
+/**
+ * Placeholder preview to exercise scanner logic around future preview-parameters support
+ * in Compose Multiplatform 1.9.0+. This intentionally has no parameters.
+ */
+@Preview
+@Composable
+fun PreviewWithParameters() {
+  Text("Preview placeholder for future Compose Multiplatform 1.9.0+ parameters support.")
+}

include-build/roborazzi-gradle-plugin/src/test/java/io/github/takahirom/roborazzi/VersionComparisonTest.kt (4)

9-14: Use the description as the display name for parameterized cases

Right now the runner prints the whole data class in test names. Overriding toString to return description makes CI output much clearer.

Apply this diff:

-data class VersionComparisonTestCase(
-    val current: String,
-    val required: String,
-    val expected: Boolean,
-    val description: String
-)
+data class VersionComparisonTestCase(
+    val current: String,
+    val required: String,
+    val expected: Boolean,
+    val description: String
+) {
+    override fun toString(): String = description
+}

---

21-23: Include the index in parameterized test names for easier triage

Adding the index helps when multiple cases share similar descriptions.

-        @Parameterized.Parameters(name = "{0}")
+        @Parameterized.Parameters(name = "{index}: {0}")

---

24-38: Strengthen coverage with SNAPSHOT and cross-pre-release ordering (rc vs beta), plus symmetry

These additional cases lock in expected behavior for commonly seen qualifiers and symmetry around shortened versions.

                 VersionComparisonTestCase("0.7.0-alpha", "0.7.0-alpha", false, "0.7.0-alpha == 0.7.0-alpha"),
-                VersionComparisonTestCase("0.7.invalid", "0.7.0", false, "0.7.invalid == 0.7.0")
+                VersionComparisonTestCase("0.7.invalid", "0.7.0", false, "0.7.invalid == 0.7.0"),
+                VersionComparisonTestCase("0.7.0-SNAPSHOT", "0.7.0", true, "0.7.0-SNAPSHOT < 0.7.0"),
+                VersionComparisonTestCase("0.7.0-rc01", "0.7.0-beta02", false, "0.7.0-rc01 !< 0.7.0-beta02"),
+                VersionComparisonTestCase("0.7.0", "0.7", false, "0.7.0 == 0.7")

---

52-75: Expand parseVersion tests to lock handling of invalid numeric parts

This codifies the intended “invalid numeric -> 0” behavior and qualifier normalization for SNAPSHOT-like versions.

     @Test
     fun `parseVersion handles case insensitive qualifier`() {
         val (nums, qualifier) = parseVersion("1.2.3-BETA")
         assertEquals("Case insensitive version numeric parts", listOf(1, 2, 3), nums)
         assertEquals("Case insensitive version qualifier", "beta", qualifier)
     }
+
+    @Test
+    fun `parseVersion treats invalid numeric parts as 0`() {
+        val (nums, qualifier) = parseVersion("1.x.3-SNAPSHOT")
+        assertEquals(listOf(1, 0, 3), nums)
+        assertEquals("snapshot", qualifier)
+    }

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.