Add dim color to dialog #697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeppeman
reviewed
Jun 13, 2025
| if ((layoutParams.flags and WindowManager.LayoutParams.FLAG_DIM_BEHIND) !== 0) { | ||
| val alpha = (layoutParams.dimAmount * 255).toInt() | ||
| val color = Color.argb(alpha, 0, 0, 0) | ||
| decorView.setBackgroundColor(color) |
There was a problem hiding this comment.
Looks like we can't use decorView here as it's only wrapping the size of the dialog body.
I noticed that this was in layoutlib, not the actual WindowManagerImpl running on Android; so they're just mimicking the behaviour of a Dimmer. So I think it's reasonable to do something similar here, I tried the following and it produced the desired results:
if ((layoutParams.flags and WindowManager.LayoutParams.FLAG_DIM_BEHIND) !== 0) {
val alpha = (layoutParams.dimAmount * 255).toInt()
val color = Color.argb(alpha, 0, 0, 0)
canvas.drawRect(Rect(0, 0, width, height), Paint().apply { this.color = color })
}There was a problem hiding this comment.
Thanks. It seems to be working correctly now. I had initially tried this, but I misunderstood and thought the semi-transparent color was filling the area with a solid color. However, I now realize that it is being drawn with the proper transparency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.