-
Notifications
You must be signed in to change notification settings - Fork 259
Comparing changes
Open a pull request
base repository: tafia/quick-xml
base: v0.35.0
head repository: tafia/quick-xml
compare: v0.36.0
- 17 commits
- 21 files changed
- 2 contributors
Commits on Jul 5, 2024
-
Move bang type checks outside of loop
(Review in whitespace changes ignored mode)
Configuration menu - View commit details
-
Copy full SHA for 8741abc - Browse repository at this point
Copy the full SHA 8741abcView commit details -
Add test for lowercase <![cdata[]]>
failures (6): syntax::cdata::lowercase::ns_reader::async_tokio syntax::cdata::lowercase::ns_reader::borrowed syntax::cdata::lowercase::ns_reader::buffered syntax::cdata::lowercase::reader::async_tokio syntax::cdata::lowercase::reader::borrowed syntax::cdata::lowercase::reader::buffered
Configuration menu - View commit details
-
Copy full SHA for 89e5360 - Browse repository at this point
Copy the full SHA 89e5360View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6dec2b2 - Browse repository at this point
Copy the full SHA 6dec2b2View commit details -
Use only uppercase DOCTYPE in tests where possible as required by the…
… specification See https://www.w3.org/TR/xml11/#NT-doctypedecl
Configuration menu - View commit details
-
Copy full SHA for b71cf7c - Browse repository at this point
Copy the full SHA b71cf7cView commit details
Commits on Jul 6, 2024
-
Merge pull request #781 from Mingun/only-upper-cdata
Start CDATA section only after uppercase `<![CDATA[`
Configuration menu - View commit details
-
Copy full SHA for 0960333 - Browse repository at this point
Copy the full SHA 0960333View commit details -
Configuration menu - View commit details
-
Copy full SHA for c195f5d - Browse repository at this point
Copy the full SHA c195f5dView commit details -
Configuration menu - View commit details
-
Copy full SHA for a4c71fb - Browse repository at this point
Copy the full SHA a4c71fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 28c031d - Browse repository at this point
Copy the full SHA 28c031dView commit details -
Do not use
Default
implementation to construct parsersThis is not generic code and it is more clear when we construct them with explicit state
Configuration menu - View commit details
-
Copy full SHA for be86267 - Browse repository at this point
Copy the full SHA be86267View commit details -
Assert syntax errors via pretty_assertions
If test will fail due to another syntax error we get a nice diff
Configuration menu - View commit details
-
Copy full SHA for 0d99a16 - Browse repository at this point
Copy the full SHA 0d99a16View commit details -
Configuration menu - View commit details
-
Copy full SHA for d387ed7 - Browse repository at this point
Copy the full SHA d387ed7View commit details -
Actually check that .error_position() is correct
Check position for zero actually does not check anything because this is start position before parse. We move position by 1 by using Text event failures (36): syntax::tag::unclosed3::ns_reader::async_tokio syntax::tag::unclosed3::ns_reader::borrowed syntax::tag::unclosed3::ns_reader::buffered syntax::tag::unclosed3::reader::async_tokio syntax::tag::unclosed3::reader::borrowed syntax::tag::unclosed3::reader::buffered syntax::tag::unclosed4::ns_reader::async_tokio syntax::tag::unclosed4::ns_reader::borrowed syntax::tag::unclosed4::ns_reader::buffered syntax::tag::unclosed4::reader::async_tokio syntax::tag::unclosed4::reader::borrowed syntax::tag::unclosed4::reader::buffered syntax::tag::unclosed5::ns_reader::async_tokio syntax::tag::unclosed5::ns_reader::borrowed syntax::tag::unclosed5::ns_reader::buffered syntax::tag::unclosed5::reader::async_tokio syntax::tag::unclosed5::reader::borrowed syntax::tag::unclosed5::reader::buffered syntax::tag::unclosed6::ns_reader::async_tokio syntax::tag::unclosed6::ns_reader::borrowed syntax::tag::unclosed6::ns_reader::buffered syntax::tag::unclosed6::reader::async_tokio syntax::tag::unclosed6::reader::borrowed syntax::tag::unclosed6::reader::buffered syntax::tag::unclosed7::ns_reader::async_tokio syntax::tag::unclosed7::ns_reader::borrowed syntax::tag::unclosed7::ns_reader::buffered syntax::tag::unclosed7::reader::async_tokio syntax::tag::unclosed7::reader::borrowed syntax::tag::unclosed7::reader::buffered syntax::tag::unclosed8::ns_reader::async_tokio syntax::tag::unclosed8::ns_reader::borrowed syntax::tag::unclosed8::ns_reader::buffered syntax::tag::unclosed8::reader::async_tokio syntax::tag::unclosed8::reader::borrowed syntax::tag::unclosed8::reader::buffered
Configuration menu - View commit details
-
Copy full SHA for ecc7ef3 - Browse repository at this point
Copy the full SHA ecc7ef3View commit details -
Fix incorrect
.error_position()
when encountering syntax error for ……open or self-closed tag
Configuration menu - View commit details
-
Copy full SHA for df65be0 - Browse repository at this point
Copy the full SHA df65be0View commit details -
Use
.error_position()
instead of.buffer_position()
in examples w……here error position is reported `.error_position()` is intended to report position where error start occurring, `.buffer_position()` is intended to show to what position reader read data tests/issues.rs leave untouched because this is the code from real problems in GH issues, it should remain as close to issue as possible
Configuration menu - View commit details
-
Copy full SHA for 45e8be4 - Browse repository at this point
Copy the full SHA 45e8be4View commit details
Commits on Jul 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6a48a28 - Browse repository at this point
Copy the full SHA 6a48a28View commit details
Commits on Jul 8, 2024
-
Merge pull request #780 from Mingun/end-attributes
Allow attributes in the `Event::End` and fix `.error_position()`
Configuration menu - View commit details
-
Copy full SHA for 959eb55 - Browse repository at this point
Copy the full SHA 959eb55View commit details -
Configuration menu - View commit details
-
Copy full SHA for 10ddcb7 - Browse repository at this point
Copy the full SHA 10ddcb7View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.35.0...v0.36.0