Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: tafia/quick-xml
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.35.0
Choose a base ref
...
head repository: tafia/quick-xml
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.36.0
Choose a head ref
  • 17 commits
  • 21 files changed
  • 2 contributors

Commits on Jul 5, 2024

  1. Move bang type checks outside of loop

    (Review in whitespace changes ignored mode)
    Mingun committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    8741abc View commit details
    Browse the repository at this point in the history
  2. Add test for lowercase <![cdata[]]>

    failures (6):
        syntax::cdata::lowercase::ns_reader::async_tokio
        syntax::cdata::lowercase::ns_reader::borrowed
        syntax::cdata::lowercase::ns_reader::buffered
        syntax::cdata::lowercase::reader::async_tokio
        syntax::cdata::lowercase::reader::borrowed
        syntax::cdata::lowercase::reader::buffered
    Mingun committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    89e5360 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6dec2b2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b71cf7c View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2024

  1. Merge pull request #781 from Mingun/only-upper-cdata

    Start CDATA section only after uppercase `<![CDATA[`
    Mingun authored Jul 6, 2024
    Configuration menu
    Copy the full SHA
    0960333 View commit details
    Browse the repository at this point in the history
  2. Sort options alphabetically

    Mingun committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    c195f5d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a4c71fb View commit details
    Browse the repository at this point in the history
  4. Remove incorrect example

    Mingun committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    28c031d View commit details
    Browse the repository at this point in the history
  5. Do not use Default implementation to construct parsers

    This is not generic code and it is more clear when we construct them with explicit state
    Mingun committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    be86267 View commit details
    Browse the repository at this point in the history
  6. Assert syntax errors via pretty_assertions

    If test will fail due to another syntax error we get a nice diff
    Mingun committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    0d99a16 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d387ed7 View commit details
    Browse the repository at this point in the history
  8. Actually check that .error_position() is correct

    Check position for zero actually does not check anything because this is start
    position before parse. We move position by 1 by using Text event
    
    failures (36):
        syntax::tag::unclosed3::ns_reader::async_tokio
        syntax::tag::unclosed3::ns_reader::borrowed
        syntax::tag::unclosed3::ns_reader::buffered
        syntax::tag::unclosed3::reader::async_tokio
        syntax::tag::unclosed3::reader::borrowed
        syntax::tag::unclosed3::reader::buffered
        syntax::tag::unclosed4::ns_reader::async_tokio
        syntax::tag::unclosed4::ns_reader::borrowed
        syntax::tag::unclosed4::ns_reader::buffered
        syntax::tag::unclosed4::reader::async_tokio
        syntax::tag::unclosed4::reader::borrowed
        syntax::tag::unclosed4::reader::buffered
        syntax::tag::unclosed5::ns_reader::async_tokio
        syntax::tag::unclosed5::ns_reader::borrowed
        syntax::tag::unclosed5::ns_reader::buffered
        syntax::tag::unclosed5::reader::async_tokio
        syntax::tag::unclosed5::reader::borrowed
        syntax::tag::unclosed5::reader::buffered
        syntax::tag::unclosed6::ns_reader::async_tokio
        syntax::tag::unclosed6::ns_reader::borrowed
        syntax::tag::unclosed6::ns_reader::buffered
        syntax::tag::unclosed6::reader::async_tokio
        syntax::tag::unclosed6::reader::borrowed
        syntax::tag::unclosed6::reader::buffered
        syntax::tag::unclosed7::ns_reader::async_tokio
        syntax::tag::unclosed7::ns_reader::borrowed
        syntax::tag::unclosed7::ns_reader::buffered
        syntax::tag::unclosed7::reader::async_tokio
        syntax::tag::unclosed7::reader::borrowed
        syntax::tag::unclosed7::reader::buffered
        syntax::tag::unclosed8::ns_reader::async_tokio
        syntax::tag::unclosed8::ns_reader::borrowed
        syntax::tag::unclosed8::ns_reader::buffered
        syntax::tag::unclosed8::reader::async_tokio
        syntax::tag::unclosed8::reader::borrowed
        syntax::tag::unclosed8::reader::buffered
    Mingun committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    ecc7ef3 View commit details
    Browse the repository at this point in the history
  9. Fix incorrect .error_position() when encountering syntax error for …

    …open or self-closed tag
    Mingun committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    df65be0 View commit details
    Browse the repository at this point in the history
  10. Use .error_position() instead of .buffer_position() in examples w…

    …here error position is reported
    
    `.error_position()` is intended to report position where error start occurring,
    `.buffer_position()` is intended to show to what position reader read data
    
    tests/issues.rs leave untouched because this is the code from real problems in GH issues,
    it should remain as close to issue as possible
    Mingun committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    45e8be4 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2024

  1. Configuration menu
    Copy the full SHA
    6a48a28 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Merge pull request #780 from Mingun/end-attributes

    Allow attributes in the `Event::End` and fix `.error_position()`
    Mingun authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    959eb55 View commit details
    Browse the repository at this point in the history
  2. Release 0.36.0

    Mingun committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    10ddcb7 View commit details
    Browse the repository at this point in the history
Loading