Skip to content

fix: set options from decorator to IsBase64 method #2383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

fix: set options from decorator to IsBase64 method #2383

wants to merge 10 commits into from

Conversation

alenap93
Copy link

Description

Now decorator IsBase64 passes options to IsBase64 method.

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

Fixes

fixes #2374

braaar
braaar previously approved these changes Mar 19, 2024
View reviewed changes
@braaar
Copy link
Member

braaar commented Mar 19, 2024

Could you run prettier to fix the formatting issue, @alenap93 ?

@daniel-mejia-deel
Copy link

Hi there! Is there any update on this @alenap93?
Your solution really solves the current issue with IsBase64 with urlSafe parameter in true!

@alenap93
Copy link
Author

alenap93 commented Jun 6, 2024

I haven't any news😞

@braaar braaar mentioned this pull request Jan 17, 2025
Merged
6 tasks
@braaar braaar closed this in #2549 Jan 17, 2025
@braaar
Copy link
Member

braaar commented Jan 17, 2025

Thank you for the PR! I just landed a slightly different version of the same fix.

@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@braaar braaar braaar left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: options for @IsBase64 decorator are ignored
3 participants
@alenap93 @braaar @daniel-mejia-deel