Skip to content

test(ci): force mocha to exit on stuck process #11538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2025
Merged

test(ci): force mocha to exit on stuck process #11538

merged 1 commit into from
Jun 21, 2025

Conversation

OSA413
Copy link
Collaborator

@OSA413 OSA413 commented Jun 20, 2025 •
edited by coderabbitai bot
Loading

Description of change

It incorporates the --exit flag to the mocha process so it tells the stuck test to exit. This makes it so that we don't waste the runner time on the stuck processes.

It's not a good practice, but a "fix" for the situation. We should probably investigate what goes wrong instead of incorporating this "fix".

Example of stuck test: https://github.com/typeorm/typeorm/actions/runs/15684954283/job/44480235851?pr=11524

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • This pull request links relevant issues as Fixes #00000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change

Summary by CodeRabbit

  • Chores
    • Updated test configuration to ensure tests exit automatically after completion.
    • Added a note for future configuration cleanup.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jun 20, 2025 •
edited
Loading

Walkthrough

The .mocharc.json configuration file was updated to add the "exit": true property, ensuring Mocha exits after test completion. A comment entry was also included as a TODO reminder to remove the --exit flag in the future, referencing the relevant Mocha documentation.

Changes

File(s) Change Summary
.mocharc.json Added "exit": true property and a "__comment" entry with a TODO and documentation link.

Poem

In the warren where tests run through,
A flag ensures we’re safely through.
“Exit true!” the rabbits cheer,
No hanging threads, the path is clear.
A comment whispers, “Someday soon,
This flag will hop away, like the moon.” 🐇🌙

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Jun 20, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.mocharc.json (1)

2-2: Use a dedicated config file or .mocharc.js for comments
JSON doesn’t support comments natively. Using the "__comment" property is a workaround that can clutter the configuration. Consider migrating to .mocharc.js (or JSONC) to enable real comments and improve maintainability.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1bcf055 and 3214cf6.

📒 Files selected for processing (1)
  • .mocharc.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: formatting
  • GitHub Check: build
  • GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (1)
.mocharc.json (1)

3-3: Approve exit flag for forcing Mocha to exit
Adding "exit": true is an effective temporary measure to prevent CI hangs. Remember to remove this flag once the underlying cause of stuck tests is resolved, as noted in the TODO.

@coveralls
Copy link

Coverage Status

coverage: 76.386%. remained the same
when pulling 3214cf6 on OSA413:mocha-force-exit-after-test
into 1bcf055 on typeorm:master.

gioboa
gioboa approved these changes Jun 20, 2025
View reviewed changes
Copy link
Collaborator

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help @OSA413

@OSA413 OSA413 merged commit 70057de into typeorm:master Jun 21, 2025
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@alumni alumni alumni approved these changes

@gioboa gioboa gioboa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OSA413 @coveralls @alumni @gioboa