test/other-issues/lazy-count/subscribers/AfterQuerySubscriber.ts (1)

8-29: Strengthen typing & encapsulation of calledQueries.

calledQueries stores raw SQL strings, yet it’s typed as any[] and left public.
Tighten the contract and avoid accidental external mutation:

-    calledQueries: any[] = []
+    private calledQueries: string[] = []

No downstream code relies on direct field access (tests use the helper methods), so this should be non-breaking while improving safety.

src/query-builder/SelectQueryBuilder.ts (1)

1892-1899: Minor issues in cache-id handling & typo

1. Typo: retreive → retrieve.
2. this.expressionMap.cacheId = cacheId ? \${cacheId}-count` : cacheId ‑ WhencacheIdisundefined` the assignment is a no-op; consider skipping it entirely to avoid the extra write.
3. The original cacheId is not restored after the count query; if the same builder instance is reused later it will carry the suffixed id.

- // Creates a new cacheId for the count query, or it will retreive the above query results
+ // Creates a new cacheId for the count query, or it will retrieve the previous query results
...
- this.expressionMap.cacheId = cacheId ? `${cacheId}-count` : cacheId
+ if (cacheId) {
+     this.expressionMap.cacheId = `${cacheId}-count`
+ }

Restore cacheId after executeCountQuery if the builder is intended to be reusable.

test/other-issues/lazy-count/lazy-count.ts (4)

29-34: Factor out test-data seeding to reduce repetition

The four for-loops that seed 2 – 5 Post rows are identical boilerplate. Extracting a small helper (e.g. await seedPosts(connection, 5)) keeps each test focused on the behaviour under scrutiny and makes future changes to the seed logic (different entity, additional fields, etc.) one-liner edits.

Also applies to: 58-63, 87-92, 116-121

---

36-38: Avoid brittle index-based access to the subscriber

connection.subscribers[0] silently breaks if another subscriber is registered first.
Prefer a type/instance lookup:

-const afterQuery = connection.subscribers[0] as AfterQuerySubscriber
+const afterQuery = connection.subscribers.find(
+    (s): s is AfterQuerySubscriber => s instanceof AfterQuerySubscriber,
+)!

This is safer and self-documenting.

---

50-52: Regex assertion may miss driver-specific COUNT syntax

The check /.?count/i assumes the raw SQL contains the literal word COUNT. Some drivers alias the aggregate (e.g. "COUNT"("*)" → "cnt") or wrap it in comments, causing false negatives/positives.
A stricter approach is to expose a boolean from AfterQuerySubscriber like wasCountExecuted instead of string-matching the SQL text.

Also applies to: 79-81, 108-110, 138-140

---

46-49: Inconsistent Chai styles (should vs expect)

Each assertion mixes the should interface (count.should.be.equal(...)) with the expect interface. While both work, sticking to one style per file avoids cognitive overhead and linter noise.

Also applies to: 75-78, 104-107, 134-137

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

test/other-issues/lazy-count/entity/Post.ts (1)

17-21: Initialize or assert the comments collection

comments is declared without a definite-assignment assertion (!) or an initial value.
With strictPropertyInitialization enabled, this triggers TS2740; at runtime it may also be undefined, forcing callers to null-check. Two quick fixes:

-    comments: Comment[]
+    comments!: Comment[]            // 💡 simplest – assert it will be set
+
+    // Or give it a safe default:
+    // comments: Comment[] = []

Either option keeps the intent clear and avoids unnecessary undefined checks.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro