Skip to content

Added very large units of length: kpc, Mpc, Gpc #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2018
Merged

Added very large units of length: kpc, Mpc, Gpc #303

merged 1 commit into from
May 9, 2018

Conversation

robotsnowfall
Copy link
Contributor

These units are handy when expressing very large distances, such as the distance between stars or galaxies.

See Parsecs_and_kiloparsecs for use cases.

Copy link
Collaborator

@cquiroz cquiroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'll wait a couple of days for other committers to comment or I'll merge

@robotsnowfall
Copy link
Contributor Author

Anything else I need to do here?

@cquiroz
Copy link
Collaborator

cquiroz commented May 9, 2018

Since there's been no comments I think this is safe to merge

@cquiroz cquiroz merged commit 988aaf3 into typelevel:master May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants