Add SI, Troy, US Customary unit groups #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix package location
Closed
|
i have another commit pending for this that adds the new objects from #227 . |
cquiroz
approved these changes
May 13, 2017
| * Puts [[Dimension]] objects into implicit scope | ||
| * so that implicit [[UnitGroup]] machinery works. | ||
| */ | ||
| object ImplicitDimensions { |
There was a problem hiding this comment.
Just a general were question. If we were going to add a new Quantity would there be compilation errors if the implicit Dimension isn't defined here? I hope that's the case 😄
There was a problem hiding this comment.
No, there wouldn't be. You'll get a compiler error if you try to use it, but this file will build just fine. Which is a problem. I'm not sure the best way to address it.
There was a problem hiding this comment.
We'd have the same issue if we wrote lots of boilerplate collecting SiUnit for each Dimension too, though.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #234 to start adding unit groups.
There are two SI unit groups, "strict" and "expanded." Strict is just those in the SI itself. Expanded adds hours, minutes, days, liters, and other non-SI units that can be used in the SI, as defined in the BIPM appendix.
I defined the SI using implicits to avoid having a massive file with lots of boilerplate calling
... collect SiUnit si ...for eachUnitOfMeasure. In order to getUnitGroups implicitly generated, I had to getDimensioninto implicit scope, which I did via theImplicitDimensionsobject. That's just boilerplate, but at least it's only one per Dimension.