Skip to content

add troy mass units and carats #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 2, 2017
Merged

add troy mass units and carats #164

merged 2 commits into from
Jan 2, 2017

Conversation

derekmorr
Copy link
Collaborator

This resolves #163 .

cquiroz
cquiroz approved these changes Jan 1, 2017
View reviewed changes
Copy link
Collaborator

@cquiroz cquiroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me
Is there any reference where the conversion values come from?

@derekmorr
Copy link
Collaborator Author

Honestly, mainly the wikipedia articles on Troy units, Tolas, and Carats.

@derekmorr
Copy link
Collaborator Author

One of the CI builds timed out, so I reran them. It all passes now.

@cquiroz cquiroz merged commit b7054b4 into master Jan 2, 2017
@cquiroz cquiroz deleted the troyunits branch January 2, 2017 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cquiroz cquiroz cquiroz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Troy Units and Carats
2 participants
@derekmorr @cquiroz