Add source code to error message of expect. #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when an
expectassertion fails, the developer sees a generalassertion failedmessage along with any clues, but needs to navigate to the source code and look up the failed expectation by its line number. This can be difficult when there are multipleexpectstatements in the same test.This PR adds the source code of
expectcalls to the error message.Adding just the source code (and not the surrounding lines) has a low maintenance overhead, and is quickest to implement. We can explore adding more context around the source code in future PRs, in a similar fashion to munit.
Current behaviour
With this PR