fix(tab-bar): fixed a bug where child tabs were not synchronizing with the active tab state #967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h the active tab state
|
|
Ross-Blakeney
approved these changes
Aug 1, 2025
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Describe the new behavior?
Rather than storing a reference to the
<forge-tab>element instances within the<forge-tab-bar>, this change swaps that out for just querying the DOM for the current child tabs at any given time when needed. This avoids any race conditions and ensures we're aways acting upon the latest DOM state, while also avoiding capturing element references which can cause memory leaks.Additional information
This was caused by the
slotchangelistener getting added after the component initializes and the DOM is rendered, which meant the internal tab references were empty.