fix(menu): allow cascading menus to use bottom and top placements if left or right isn't available #964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…left or right isn't available
|
|
|
View Storybook Deployment |
nickonometry
approved these changes
Jul 30, 2025
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Describe the new behavior?
Previously cascading child menus would only allow either left or right fallback placements. This caused issues on smaller viewports where menus could potentially not fit on either side of the parent menu. This change adds additional fallback placements of bottom and top to try for this scenario in that order. This should allow for more graceful handling of menus on smaller viewports to ensure the user can still access the menu options.
Additional information
While this change allows a graceful fallback, using cascading menus on mobile viewports should be avoided due to usability concerns.