feat(date-picker): add new dateFormat and shortcuts APIs to allow for alternative built-in date formats
#959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for alternative built-in date formats
|
|
|
View Storybook Deployment |
samrichardsontylertech
approved these changes
Jul 10, 2025
There was a problem hiding this comment.
This all looks good to me. I'm a little split on shortcuts because it could also be handled by the consumer with an event listener on the <input>, but similar libraries include hooks like this and I generally appreciate those. It's also probably better for consistency to handle the actual event from our code.
Ross-Blakeney
approved these changes
Jul 10, 2025
MikeMatusz
approved these changes
Jul 10, 2025
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Describe the new behavior?
Added a new
dateFormatproperty (date-formatattribute) to allow for developers to use a preset built-in alternative date format. This reduces the burden on developers to use custom parse and format callbacks, and avoids complexity related to the input mask and value coercion logic.Additionally because the built-in
"n"and"t"keyboard shortcuts for setting the "today" date value can conflict with formats that use theMMMblock, we will automatically adjust the shortcuts when those formats are chosen. A newshortcutsproperty/attribute has also been added to allow for turning off the shortcuts manually, or to provide custom single character shortcuts.