Skip to content

fix(date-picker): toggle button will inherit density of text field if necessary #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2025

Conversation

DRiFTy17
Copy link
Collaborator

@DRiFTy17 DRiFTy17 commented Jul 1, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added/updated: N
  • Docs have been added/updated: N
  • Does this PR introduce a breaking change? N
  • I have linked any related GitHub issues to be closed when this PR is merged? N

Describe the new behavior?

The toggle button that is created dynamically and appended to the slotted <forge-text-field> will no adapt its density based on the density of the text-field.

Additional information

At this point in time, we only need to adapt the density when a text-field is using the "extra-small"` density

@DRiFTy17 DRiFTy17 requested a review from a team as a code owner July 1, 2025 13:16
@DRiFTy17 DRiFTy17 added patch Increment the patch version when merged skip-release Preserve the current version when merged labels Jul 1, 2025
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@DRiFTy17 DRiFTy17 merged commit 6b51f83 into main Jul 1, 2025
10 checks passed
@DRiFTy17 DRiFTy17 deleted the fix-date-picker-toggle-density branch July 1, 2025 17:04
Copy link
Contributor

github-actions bot commented Jul 2, 2025

🚀 PR was released in v3.9.2 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released. skip-release Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants