Skip to content

fix(popover): fixed a bug where popovers open after current were closing when hovered #931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 30, 2025

Conversation

DRiFTy17
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added/updated: Y
  • Docs have been added/updated: N
  • Does this PR introduce a breaking change? N
  • I have linked any related GitHub issues to be closed when this PR is merged? N

Describe the new behavior?

Previously if you were to use the hover trigger type with two popovers and hover over the first anchor element open the first popover, then quickly hover over the second anchor element to open the second popover, both popovers would close when the first popover hover dismiss delay timeout is reached.

This change fixes that by only attempting to auto-dismiss other popovers in the dismissible stack that are children of the popover that is closing.

@DRiFTy17 DRiFTy17 requested a review from nickonometry May 28, 2025 17:51
@DRiFTy17 DRiFTy17 requested a review from a team as a code owner May 28, 2025 17:51
@DRiFTy17 DRiFTy17 added the patch Increment the patch version when merged label May 28, 2025
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

nickonometry
nickonometry previously approved these changes May 29, 2025
@DRiFTy17 DRiFTy17 added the skip-release Preserve the current version when merged label May 30, 2025
@DRiFTy17 DRiFTy17 merged commit ea37026 into main May 30, 2025
10 checks passed
@DRiFTy17 DRiFTy17 deleted the fix-popover-hover-dismiss branch May 30, 2025 16:17
Copy link
Contributor

github-actions bot commented Jun 9, 2025

🚀 PR was released in v3.9.0 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released. skip-release Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants