feat: upgrade tyler-icons to consolidated v2.x version #911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nickonometry
approved these changes
Apr 16, 2025
Ross-Blakeney
approved these changes
May 22, 2025
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Describe the new behavior?
Upgrades to the consolidated version (v2.x) of
@tylertech/tyler-iconswhere all icons are exported from the same module, which eliminates needing to know the icon set. All icons are now deduplicated and available from a single module export at the root of the package.This change collapses import states down to a single import, as well as upgrades the dependency to this new version.
The
<forge-icon>component now defaults to the"all"value for theexternalTypewhich means it will request icons from the consolidated set dynamically now, unless the legacy types are specified. The icon format in tyler-icons 2.x is compatible with theIconRegistrystill so either 1.x or 2.x can be used interchangeably in an app.