fix(list-item): fixed a bug where multiple clicks on the interactive element could occur #905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…element could occur
|
|
MikeMatusz
approved these changes
Apr 8, 2025
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Describe the new behavior?
Current behavior inspects the composed path for interactive events on a list item (mousedown, click, and keydown) to look for specific elements within the path of elements that event took. Since the composed path contains ALL elements within the bubbling path, it could potentially match against elements we don't care about since it's outside the scope of the specific list item.
This change adds a new utility to capture only composed elements on an event path starting from a specific element. In this case we only care about direct children of the list item.