Skip to content

fix: updated how overlay positioning is handled when overflowing the viewport bounds #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 1, 2025
Merged

fix: updated how overlay positioning is handled when overflowing the viewport bounds #883

merged 6 commits into from
Apr 1, 2025

Conversation

DRiFTy17
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added/updated: Y
  • Docs have been added/updated: Y
  • Does this PR introduce a breaking change? N
  • I have linked any related GitHub issues to be closed when this PR is merged? N

Describe the new behavior?

  • Removed usage of default fallback placements in favor of relying fully on floating-ui's computed best fit positioning strategy
  • Adjusted how we handle ensuring popovers stay in view with overflow
  • Enable floating-ui's shift middleware by default and adjusted typings for shift API on overlay to accept specific string values.
  • Allow for shift to continue to accept boolean values for backwards compatibility.
  • Use visibility: hidden for hide state instead of display: none per floating-ui docs

@DRiFTy17 DRiFTy17 added patch Increment the patch version when merged skip-release Preserve the current version when merged storybook-preview labels Mar 27, 2025
@DRiFTy17 DRiFTy17 requested a review from a team as a code owner March 27, 2025 17:17
@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions GitHub Actions
Copy link
Contributor

View Storybook Deployment
pr/tyler-technologies-oss:overlay-positioning-fixes

@DRiFTy17 DRiFTy17 merged commit 7cf07b1 into main Apr 1, 2025
7 checks passed
@DRiFTy17 DRiFTy17 deleted the overlay-positioning-fixes branch April 1, 2025 14:42
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2025

🚀 PR was released in v3.8.0 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Apr 3, 2025
@DRiFTy17 DRiFTy17 mentioned this pull request Apr 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samrichardsontylertech samrichardsontylertech samrichardsontylertech approved these changes

Assignees
No one assigned
Labels
patch Increment the patch version when merged released This issue/pull request has been released. skip-release Preserve the current version when merged storybook-preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DRiFTy17 @samrichardsontylertech