feat(badge): refactor to use Lit #879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
DRiFTy17
commented
Mar 22, 2025
| } | ||
| /** The theme of the badge. */ | ||
| @property({ type: String, reflect: true }) | ||
| public theme: BadgeTheme = 'default'; |
There was a problem hiding this comment.
I chose not to for this first pass, but should we consider also using CSS custom states for these common theme properties across components? What sort of naming convention would we use? :state(theme-primary) or :state(primary)?
There was a problem hiding this comment.
I don't think so. I've been reserving custom states for particular things like disabled, open, etc. It feels cleaner for them to refer to behavioral changes in the components instead of purely stylistic ones. We can always add states later if there's a need, anyway 🤷
samrichardsontylertech
approved these changes
Mar 27, 2025
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.