feat(dialog): add "reason" for why dialog is about to close to event detail
#875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
samrichardsontylertech
approved these changes
Mar 27, 2025
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Describe the new behavior?
The
forge-dialog-before-closecustom event will now contain an object in itsdetailproperty that provides thereasonas to why the dialog is closing. This event will dispatch whenever a light dismiss action occurs (which will provide whether the escape key was pressed or the backdrop was clicked to trigger the light dismiss), or when the dialog is closed viaformmethod="dialog"submission.Additional information
This primarily exposes the ability for developers to handle light dismiss actions differently whether that is triggered via escape key press or backdrop click, and potentially handle those to actions differently if desired.
Ideally light dismiss should be controlled via
persistentas a whole, but there may be scenarios where handling each action differently is necessary.