Skip to content

fix(dialog): use capturing keydown listener #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2025
Merged

fix(dialog): use capturing keydown listener #869

merged 1 commit into from
Mar 22, 2025

Conversation

DRiFTy17
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added/updated: N
  • Docs have been added/updated: N
  • Does this PR introduce a breaking change? N
  • I have linked any related GitHub issues to be closed when this PR is merged? N

Describe the new behavior?

Use a capturing listener to ensure the dialog can respond and potentially cancel the event as soon as possible.

@DRiFTy17 DRiFTy17 added patch Increment the patch version when merged skip-release Preserve the current version when merged labels Mar 17, 2025
@DRiFTy17 DRiFTy17 requested a review from a team as a code owner March 17, 2025 12:57
@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@DRiFTy17 DRiFTy17 merged commit 58d2300 into main Mar 22, 2025
13 checks passed
@DRiFTy17 DRiFTy17 deleted the dialog-keydown-capture branch March 22, 2025 02:42
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2025

🚀 PR was released in v3.8.0 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samrichardsontylertech samrichardsontylertech samrichardsontylertech approved these changes

Assignees
No one assigned
Labels
patch Increment the patch version when merged released This issue/pull request has been released. skip-release Preserve the current version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DRiFTy17 @samrichardsontylertech