fix(button): use grid layout instead of flex to avoid text nodes collapsing #867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
samrichardsontylertech
approved these changes
Mar 14, 2025
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Describe the new behavior?
Switch to a grid layout instead of flex to allow for the button to control its layout, rather than relying on slotted children for dimensions.
Additionally, now that grid is used, I've set the default block padding to
0because it was interfering with the static height of the button in terms of content alignment.Additional information
This fixes a bug in Safari where the text nodes were collapsing due to the flex layout, and slotted selectors could not apply to text nodes to control the flex item dimensions... Using a grid layout should give more control regardless.