add a sanitized version of the hostname (replace any character matchi… #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng [^a-zA-Z0-9\-.] with underscore) fixes txn2#240
|
@hosswald, thanks for the PR. However, if we do this, we should use https://en.wikipedia.org/wiki/Hostname In addition, it should strip any leading or trailing |
|
@cjimti changed it. Now everything that is not alphanumeric is replaced with dash, and leading/trailing dashes are stripped. Please review. |
…placed with dash * leading and trailing dashes are stripped * added test txn2#240
|
I think this helps the majority of people in your situation. I don't know that umlauts/emoji, etc are a problem, but this is a good start. Thanks |
D3-LucaPiombino
pushed a commit
to CodeCoil/kubefwd
that referenced
this pull request
Jun 13, 2024
add a sanitized version of the hostname (replace any character matchi…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a sanitized version of the hostname (replace any character matching [^a-zA-Z0-9\-.] with underscore)
fixes #240