Add client option for literal URLs #277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
235b409 to
fd98ac9
Compare
|
@marioizquierdo I am not 100% sure on the name for the public method Other than that, this PR is ready to merge |
|
I'm adding a patch to get it ready. We just conflicted merging from master at the same time heh. Will be ready in a few minutes and I'll merge. Thanks fro this work! |
|
Updated to keep the client implementation with a single list of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#244 , #257
Description of changes:
Adds a new client option to use literal URLs instead of the default CamelCased ones.
The updated test in
internal/twirptest/snake_case_namescovers behaviour of both the client and the server.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.