Forced proto3 OPTIONAL feature flag, deps updated #275
Conversation
ad00483 to
aaa5ea5
Compare
|
Is this related to issue #222 ? |
|
@marioizquierdo hello, sorry for the delay. It's related to: https://github.com/protocolbuffers/protobuf/blob/v3.12.0/docs/implementing_proto3_presence.md |
|
This PR is stale because it has been open for 60 days with no activity. Remove stale label / comment or this will be closed in 5 days |
|
@Solution Could you include the license agreement from the pull request template? We'll try to have this reviewed in the coming weeks. |
|
@3ventic ofc, i'll do that. |
|
This PR is stale because it has been open for 60 days with no activity. Remove stale label / comment or this will be closed in 5 days |
|
There's an upcoming update with #304 to update to Protobuf APIV2. That will cleanup all the dependency updates that were done in this branch. Could you isolate the changes needed to support the OPTIONAL feature flag in Twirp after the update to Protobuf APIV2 update is made? |
|
Closing this. The v8.0.0 release adds support for Protobuf APIv2 which allows Twirp services to use new features introduced on new versions of Protobuf for Go. LMK if there's anything else I'm missing. Thanks! |
Hello guys,
i've added support for OPTIONAL feature flag which is coming with new version of protobuf, since the twirp it's not generating the .pb files, it doesn't need to implement anything in code generator, so it'll have no impact on gen-twirp.
Issue:
.proto is a proto3 file that contains optional fields, but code generator protoc-gen-twirp hasn't been updated to support optional fields in proto3. Please ask the owner of this code generator to support proto3 optional.--twirp_out:What i did:
I tried to minimize the impact of upgrading the protobuf deps, but there's lot of changes since the last vendor update.
All tests passing.
//edit:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.