There seems to be a bug in the go code generation that leads to context updates in Error server hooks failing to reach the ResponseSent hook.

callError on line 276 returns a new context, which is ignored, rather than overriding ctx.

This behavior is critical for finishing spans correctly in the twirp/datadog integration. In general, this behavior is critical any time the error hook wants to pass state down to the response sent callback.

Edit: This bug only manifests in a rare edge case, when writing the response fails. Normal application errors go through writeError in the generated code, which does update ctx correctly based on callError before calling callResponseSent.