Skip to content

GHC 9.2 #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2021
Merged

GHC 9.2 #779

merged 1 commit into from
Nov 16, 2021

Conversation

amesgen
Copy link
Member

@amesgen amesgen commented Sep 20, 2021 •
edited
Loading

Closes #794
Closes #768 (promoted infix data constructors)
Closes #659 Closes #709 Closes #705 (RecordDot* stuff)

The most significant in ghc-lib-parser-9.2 is EPA (exact print annotations). This blog post gives a good overview. A few points:

  • Most constructs are no longer wrapped in a Located, but rather in a GenLocated (SrcSpanAnn' a), where SrcSpanAnn' ~ (a, SrcSpan). GHC.Parser.Annotation gives a good overview of the new combinators for these types.
  • API annotations are contained in the AST, so we can remove our Anns stuff.
  • TTG (trees that grow) fields are now way more often actually used for EPAs, rather than being NoExtField.

EDIT: This PR introduces a benign style issue: #810

@amesgen amesgen force-pushed the amesgen/ghc-9.2 branch 2 times, most recently from 4e0087b to 341db9a Compare September 27, 2021 11:44
@amesgen amesgen force-pushed the amesgen/ghc-9.2 branch 2 times, most recently from 51cc038 to 4635385 Compare October 18, 2021 08:45
@amesgen amesgen marked this pull request as ready for review October 18, 2021 10:57
mrkkrp
mrkkrp approved these changes Oct 19, 2021
View reviewed changes
@amesgen amesgen mentioned this pull request Oct 19, 2021
Open
@amesgen amesgen force-pushed the amesgen/ghc-9.2 branch 4 times, most recently from 597d0c8 to 3adde79 Compare October 28, 2021 13:32
@amesgen
Copy link
Member Author

amesgen commented Oct 31, 2021 •
edited
Loading

Upgrading from 9.2.1-rc1 to 9.2.1 only required two minor changes: https://gist.github.com/amesgen/c77ab54959903ebc5e3734ad630e8c93

The only thing missing now is mrkkrp/ghc-syntax-highlighter#24

@mrkkrp
Copy link
Member

mrkkrp commented Oct 31, 2021

Is there something that still prevents us from testing with 9.2.1 on CI?

@amesgen
Copy link
Member Author

amesgen commented Oct 31, 2021 •
edited
Loading

@amesgen amesgen mentioned this pull request Nov 5, 2021
Closed
@amesgen amesgen force-pushed the amesgen/ghc-9.2 branch 2 times, most recently from 430af6a to f83c47f Compare November 13, 2021 13:57
mrkkrp
mrkkrp reviewed Nov 16, 2021
View reviewed changes
Copy link
Member

@mrkkrp mrkkrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is another round of review, since I saw some new changes. I think we are very close to finally merging this into master.

@amesgen amesgen force-pushed the amesgen/ghc-9.2 branch 3 times, most recently from 4bfdcea to d1ad5fe Compare November 16, 2021 16:03
@mrkkrp mrkkrp merged commit 11cda4c into master Nov 16, 2021
@mrkkrp mrkkrp deleted the amesgen/ghc-9.2 branch November 16, 2021 17:16
@mrkkrp mrkkrp mentioned this pull request Nov 16, 2021
Merged
@amesgen amesgen mentioned this pull request Nov 17, 2021
Merged
@brandonchinn178 brandonchinn178 mentioned this pull request Apr 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrkkrp mrkkrp mrkkrp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@amesgen @mrkkrp