Skip to content

Android tabs padding #376

@silvenon

Description

@silvenon

Android theme has tabs on the top, while the base and iOS theme have them on the bottom. The problem is that .content is still styled to have bottom padding, rather than top. This is a bit tricky to fix, precedence-wise.

// base.scss
// Tab bar padding
.bar-tab ~ .content {
  padding-bottom: $bar-tab-height;
}
// theme-android.scss
.bar-tab ~ .content {
  padding-bottom: $bar-tab-height;
}

The latter should be:

// theme-android.scss
.bar-tab ~ .content {
  padding-top: $bar-tab-height;
  padding-bottom: 0;
}

But then these would get overwritten:

// base.scss
// Footer bar padding
.bar-footer ~ .content {
  padding-bottom: $bar-base-height;
}
.bar-footer-secondary ~ .content {
  padding-bottom: ($bar-base-height*2);
}

Seems like some style duplication is in order?

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions