Make notebooks searchable #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for the PR. Nice work! I hope to go over your changes on the weekend. |
|
Lgtm! I noticed that the actions to change text size (Cmd-+/-/0) were no longer working with |
tuxu
added a commit
that referenced
this pull request
Jul 19, 2021
WKWebView, introduced in #28, no longer comes with actions to change the zoom factor. Scale using the CSS 'zoom' property instead.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables text search in notebooks.
To accomplish this:
WebViewto the newerWKWebView.performTextFinderAction(_:)action.ViewControllerwas extended to serve as aNSTextFinderBarContainerand mediate between anNSTextFinderand theWKWebView.Note that bugs in WebKit seem to prevent incremental search from working properly. I left incremental search disabled to avoid various fragile-seeming workarounds that are discussed around the web.