Use app name as executableName for linux build only #9412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
271313b to
b2164b7
Compare
charlag
approved these changes
Jul 31, 2025
b2164b7 to
e3b4627
Compare
According to the electron-builder docs, executableName defaults to the productName when not specified. However, in reality it was actually using the app name as default for the linux build, which is a bug that got patched recently, see: electron-userland/electron-builder#8766 Because we relied on this bug and on executableName defaulting to app name for the linux build, we explicitly set it to appName for all builds, see: f81fddd, but this caused an executableName change on MacOS. Close #9389
e3b4627 to
2c59f12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the electron-builder docs, executableName defaults to the productName when not specified. However, in reality it was actually using the app name as default for the linux build, which is a bug that got patched recently, see:
electron-userland/electron-builder#8766
Because we relied on this bug and on executableName defaulting to app name for the linux build, we explicitly set it to appName for all builds, see: f81fddd, but this caused an executableName change on MacOS.
Close #9389